src/messages.js - Issue 1219943002: Expose SIMD.Float32x4 type to Javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.js

Issue 1219943002: Expose SIMD.Float32x4 type to Javascript. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Don't install SIMD object without the simd flag. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.js

diff --git a/src/messages.js b/src/messages.js

index d7ca7cd6479bd85bbdecf3647dc941ae4c9460a1..6490ed30eb774050e46d23b4d4bae56bd33b891d 100644

--- a/src/messages.js

+++ b/src/messages.js

@@ -86,6 +86,7 @@ function NoSideEffectToString(obj) {

return str;

}

if (IS_SYMBOL(obj)) return %_CallFunction(obj, $symbolToString);

+ if (IS_FLOAT32X4(obj)) return %_CallFunction(obj, $float32x4ToString);

if (IS_OBJECT(obj)

&& %GetDataProperty(obj, "toString") === ObjectToString) {

var constructor = %GetDataProperty(obj, "constructor");