src/types.cc - Issue 1219943002: Expose SIMD.Float32x4 type to Javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/types.cc

Issue 1219943002: Expose SIMD.Float32x4 type to Javascript. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Andreas' review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/types.cc

diff --git a/src/types.cc b/src/types.cc

index 1c6b84e2dc67da07ce3c809810b163bf306e2ca1..6bbf655b164ea97976ab25fde4249d8827b795ed 100644

--- a/src/types.cc

+++ b/src/types.cc

@@ -228,6 +228,9 @@ TypeImpl<Config>::BitsetType::Lub(i::Map* map) {

}

case HEAP_NUMBER_TYPE:

return kNumber & kTaggedPointer;

+ case FLOAT32X4_TYPE:

+ // TODO(bbudge): Add type bits for SIMD value types.

+ return kAny;

case JS_VALUE_TYPE:

case JS_DATE_TYPE:

case JS_OBJECT_TYPE: