src/ia32/full-codegen-ia32.cc - Issue 1219943002: Expose SIMD.Float32x4 type to Javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 1219943002: Expose SIMD.Float32x4 type to Javascript. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Andreas' review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index b8beaaa1f31c585a11827b31538dd7095ea2deb0..b542c5d7e1e98e2bf2499ceff56e77abf5a097f4 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -5179,6 +5179,10 @@ void FullCodeGenerator::EmitLiteralCompareTypeof(Expression* expr,

__ JumpIfSmi(eax, if_false);

__ CmpObjectType(eax, SYMBOL_TYPE, edx);

Split(equal, if_true, if_false, fall_through);

+ } else if (String::Equals(check, factory->float32x4_string())) {

+ __ JumpIfSmi(eax, if_false);

+ __ CmpObjectType(eax, FLOAT32X4_TYPE, edx);

+ Split(equal, if_true, if_false, fall_through);

} else if (String::Equals(check, factory->boolean_string())) {

__ cmp(eax, isolate()->factory()->true_value());

__ j(equal, if_true);