Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: src/types.cc

Issue 1219943002: Expose SIMD.Float32x4 type to Javascript. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/types.cc
diff --git a/src/types.cc b/src/types.cc
index 1c6b84e2dc67da07ce3c809810b163bf306e2ca1..6228237f8c5bd74f4337ede3571e9daf3b5c79a7 100644
--- a/src/types.cc
+++ b/src/types.cc
@@ -228,6 +228,9 @@ TypeImpl<Config>::BitsetType::Lub(i::Map* map) {
}
case HEAP_NUMBER_TYPE:
return kNumber & kTaggedPointer;
+ // TODO(bbudge): Add type bits for SIMD value types.
rossberg 2015/07/02 13:35:43 Nit: move down comment by one line
bbudge 2015/07/06 23:59:05 Done.
+ case FLOAT32X4_TYPE:
+ return kAny;
case JS_VALUE_TYPE:
case JS_DATE_TYPE:
case JS_OBJECT_TYPE:
@@ -293,6 +296,7 @@ TypeImpl<Config>::BitsetType::Lub(i::Object* value) {
return Lub(value->Number()) &
(value->IsSmi() ? kTaggedSigned : kTaggedPointer);
}
+ if (value->IsFloat32x4()) return kAny;
rossberg 2015/07/02 13:35:43 This shouldn't be needed, since it's covered by th
bbudge 2015/07/06 23:59:05 Done.
return Lub(i::HeapObject::cast(value)->map());
}

Powered by Google App Engine
This is Rietveld 408576698