Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: sky/sdk/example/demo_launcher/lib/main.dart

Issue 1219933004: Make it harder to forget itemCount for FixedHeightScrollable (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: address ian's comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/sdk/example/stocks/lib/stock_home.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/example/demo_launcher/lib/main.dart
diff --git a/sky/sdk/example/demo_launcher/lib/main.dart b/sky/sdk/example/demo_launcher/lib/main.dart
index 458f204c87827736cb8072a01e525823afb4b2cf..139325479f4b99107c7d409f32f0189f448f56bd 100644
--- a/sky/sdk/example/demo_launcher/lib/main.dart
+++ b/sky/sdk/example/demo_launcher/lib/main.dart
@@ -129,9 +129,9 @@ const double kCardHeight = 120.0;
const EdgeDims kListPadding = const EdgeDims.all(4.0);
class DemoList extends FixedHeightScrollable {
- DemoList({ String key }) : super(key: key, itemHeight: kCardHeight, padding: kListPadding) {
- itemCount = demos.length;
- }
+ DemoList({ String key }) : super(key: key, itemHeight: kCardHeight, padding: kListPadding);
+
+ int get itemCount => demos.length;
Widget buildDemo(SkyDemo demo) {
return new Listener(
« no previous file with comments | « no previous file | sky/sdk/example/stocks/lib/stock_home.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698