Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1219923010: Enable and fix tests after page serializer merge (Closed)

Created:
5 years, 5 months ago by Tiger (Sony Mobile)
Modified:
5 years, 5 months ago
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable and fix tests after page serializer merge Enable and fix two SavePageBrowserTests and two BrowserEncodingTest that where removed in <https://codereview.chromium.org/1218743006/>; in preparation of the page serializer merger in <https://codereview.chromium.org/1177733003/>;. Patch from gustav.tiger@sonymobile.com R=jochen@chromium.org, rdsmith@chromium.org BUG=328354 Committed: https://chromium.googlesource.com/chromium/src/+/bbf281076da0c593ec9d586eb78b2498581d070e

Patch Set 1 #

Messages

Total messages: 18 (5 generated)
Tiger (Sony Mobile)
PTAL
5 years, 5 months ago (2015-07-08 09:37:34 UTC) #1
Randy Smith (Not in Mondays)
LGTM.
5 years, 5 months ago (2015-07-08 13:17:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219923010/1
5 years, 5 months ago (2015-07-08 21:04:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/71107) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-08 21:09:12 UTC) #6
Tiger (Sony Mobile)
Does this need to be committed manually? I can download the patch and build it ...
5 years, 5 months ago (2015-07-09 09:38:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219923010/1
5 years, 5 months ago (2015-07-09 09:38:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/71361) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-09 09:40:48 UTC) #11
Tiger (Sony Mobile)
jochen: can you take a look at this as well?
5 years, 5 months ago (2015-07-09 12:39:10 UTC) #13
Randy Smith (Not in Mondays)
Usually a "patch failed" error on the bots means that there's some merge problem between ...
5 years, 5 months ago (2015-07-09 13:10:22 UTC) #14
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-10 08:56:24 UTC) #15
Mattias Nissler (ping if slow)
Committed patchset #1 (id:1) manually as bbf281076da0c593ec9d586eb78b2498581d070e (presubmit successful).
5 years, 5 months ago (2015-07-10 10:05:31 UTC) #16
Alexander Alekseev
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1255223003/ by alemate@chromium.org. ...
5 years, 4 months ago (2015-07-27 20:45:23 UTC) #17
tkent
5 years, 4 months ago (2015-08-17 03:13:23 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1301503003/ by tkent@chromium.org.

The reason for reverting is: Needs to revert Blink 198503, which this depends
on.
.

Powered by Google App Engine
This is Rietveld 408576698