Issue 1219923007: Revert of history.pushState() should take care of scrolling state

Issue 1219923007: Revert of history.pushState() should take care of scrolling state (Closed)

Created:
5 years, 5 months ago by Abhijeet Kandalkar Slow

Modified:
5 years, 5 months ago

Reviewers:
vivekg, Nate Chapin

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of history.pushState() should take care of scrolling state (patchset #5 id:120001 of https://codereview.chromium.org/1063573002/) Reason for revert: Reason for revert: Reverting because of regression on Windows 8. Refer bug url https://code.google.com/p/chromium/issues/detail?id=500453 Original issue's description: > history.pushState() should take care of scrolling state. > > Current implementation don't save scrolling state while calling history > pushState() therefore history entries doesn't have information about > scrolloffset of page. While calling history.back(), wrong values of scroll > offset are considered and page jump to top. The patch adds an implementation > to save scrolling state while calling history.pushState(). > > BUG=472023 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193603 TBR=vivekg@chromium.org,japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198418

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -33 lines)			Patch
D	LayoutTests/http/tests/navigation/same-document-scroll-position-restore-pushstate.html	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	LayoutTests/http/tests/navigation/same-document-scroll-position-restore-pushstate-expected.txt	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

Abhijeet Kandalkar Slow

Created Revert of history.pushState() should take care of scrolling state

5 years, 5 months ago (2015-07-07 10:32:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219923007/1

5 years, 5 months ago (2015-07-07 10:32:16 UTC) #2

commit-bot: I haz the power

No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...

5 years, 5 months ago (2015-07-07 10:32:19 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219923007/1

5 years, 5 months ago (2015-07-07 18:34:41 UTC) #7

commit-bot: I haz the power

5 years, 5 months ago (2015-07-07 18:35:51 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198418