Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1219923005: Build setup_unittests everywhere that installer_util_unittests is built. (Closed)

Created:
5 years, 5 months ago by grt (UTC plus 2)
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@iwt
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build setup_unittests everywhere that installer_util_unittests is built. BUG=153829 Committed: https://crrev.com/5ee4e8d2c78987343e89c810ec8e70273878e8dd Cr-Commit-Position: refs/heads/master@{#337497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/all.gyp View 3 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
grt (UTC plus 2)
Hi Dirk, Please take a look at this simple change that will start building setup_unittests ...
5 years, 5 months ago (2015-07-06 14:50:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219923005/1
5 years, 5 months ago (2015-07-06 15:13:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-06 17:22:40 UTC) #6
Dirk Pranke
lgtm
5 years, 5 months ago (2015-07-06 21:28:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219923005/1
5 years, 5 months ago (2015-07-06 22:08:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 22:20:00 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 22:22:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ee4e8d2c78987343e89c810ec8e70273878e8dd
Cr-Commit-Position: refs/heads/master@{#337497}

Powered by Google App Engine
This is Rietveld 408576698