Issue 1219893005: Delete interface_impl.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1219893005: Delete interface_impl.h. (Closed)

Created:
5 years, 5 months ago by viettrungluu

Modified:
5 years, 5 months ago

Reviewers:
rudominer

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Delete interface_impl.h. R=rudominer@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/67bba571021d8d42dc8e1d7e4e58a6475697b752

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -182 lines)			Patch
M	mojo/public/cpp/application/interface_factory.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	mojo/public/cpp/bindings/interface_impl.h	View	1 chunk	+0 lines, -178 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/validation_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/viewer/document_view.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 5 months ago (2015-07-07 23:37:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
67bba571021d8d42dc8e1d7e4e58a6475697b752 (presubmit successful).

Expand Messages | Collapse Messages