Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1219873002: Thread through a flag to force SkPicture::playback() when recording subpictures. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, jvanverth1
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Thread through a flag to force SkPicture::playback() when recording subpictures. This makes nanobench picture recording benchmarks somewhat useful again, as opposed to all taking about 5us to run no matter the content. ATTN Sheriff: this will probably trigger perf.skia.org alerts. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d711d115d28b9838303dcc232516aa2f552f3a2a

Patch Set 1 #

Patch Set 2 : no need to change here. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M bench/RecordingBench.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M include/core/SkPictureRecorder.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/core/SkRecorder.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein_C
5 years, 5 months ago (2015-06-30 17:27:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219873002/20001
5 years, 5 months ago (2015-06-30 17:27:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-30 17:43:15 UTC) #6
reed1
Is this just for testing internally, or a real feature for clients? i.e. can we ...
5 years, 5 months ago (2015-07-01 13:57:28 UTC) #7
mtklein
On 2015/07/01 13:57:28, reed1 wrote: > Is this just for testing internally, or a real ...
5 years, 5 months ago (2015-07-01 14:03:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219873002/20001
5 years, 5 months ago (2015-07-01 14:04:07 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 14:04:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d711d115d28b9838303dcc232516aa2f552f3a2a

Powered by Google App Engine
This is Rietveld 408576698