Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/analyzer/test/file_system/physical_resource_provider_test.dart

Issue 1219863004: (TBR) patch test on Windows pending investigation (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/file_system/physical_resource_provider_test.dart
diff --git a/pkg/analyzer/test/file_system/physical_resource_provider_test.dart b/pkg/analyzer/test/file_system/physical_resource_provider_test.dart
index cd9cfbbadd9a5ed6407d2d661a73b7d36fcfa08c..7898bb92000f2b173c902f4ad8eb1377feeaf479 100644
--- a/pkg/analyzer/test/file_system/physical_resource_provider_test.dart
+++ b/pkg/analyzer/test/file_system/physical_resource_provider_test.dart
@@ -296,7 +296,14 @@ class PhysicalResourceProviderTest extends _BaseTest {
file.deleteSync();
return _delayed(() {
expect(changesReceived, hasLength(1));
- expect(changesReceived[0].type, equals(ChangeType.REMOVE));
+ if (io.Platform.isWindows) {
+ // TODO(danrubel) https://github.com/dart-lang/sdk/issues/23762
+ // This test fails on Windows but a similar test in the underlying
+ // watcher package passes on Windows.
+ expect(changesReceived[0].type, equals(ChangeType.MODIFY));
+ } else {
+ expect(changesReceived[0].type, equals(ChangeType.REMOVE));
+ }
expect(changesReceived[0].path, equals(path));
});
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698