Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1219853004: [es6] Initial support for let/const bindings in sloppy mode (Closed)

Created:
5 years, 5 months ago by arv (Not doing code reviews)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Initial support for let/const bindings in sloppy mode Allow let in sloppy mode with --harmony-sloppy Allow ES'15 const in sloppy mode with --harmony-sloppy --no-legacy-const Functions in block are not done yet. They are only let bound in the block at this point. BUG=v8:3305, v8:2198 LOG=N R=littledan@chromium.org, rossberg@chromium.org, adamk@chromium.org Committed: https://crrev.com/3b1aabc960ea7a1107c8b6ebb8f2b4ce48e9b610 Cr-Commit-Position: refs/heads/master@{#29536}

Patch Set 1 #

Patch Set 2 : git rebase #

Total comments: 2

Patch Set 3 : Cleanup #

Total comments: 5

Patch Set 4 : Updated tests and comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -33 lines) Patch
M src/parser.cc View 1 2 8 chunks +12 lines, -10 lines 0 comments Download
M src/preparser.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/preparser.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 2 chunks +50 lines, -2 lines 0 comments Download
M test/mjsunit/es6/block-leave.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/harmony/block-const-assign-sloppy.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/mjsunit/harmony/block-for-sloppy.js View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/harmony/block-leave-sloppy.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + test/mjsunit/harmony/block-let-crankshaft-sloppy.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/mjsunit/harmony/block-let-declaration-sloppy.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/harmony/block-let-semantics-sloppy.js View 1 2 3 2 chunks +3 lines, -2 lines 1 comment Download
A + test/mjsunit/harmony/block-scoping-sloppy.js View 1 2 1 chunk +1 line, -3 lines 0 comments Download
A + test/mjsunit/harmony/block-scoping-top-level-sloppy.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (3 generated)
arv (Not doing code reviews)
This depends on https://codereview.chromium.org/1218803006/
5 years, 5 months ago (2015-07-07 21:57:35 UTC) #1
arv (Not doing code reviews)
On 2015/07/07 21:57:35, arv wrote: > This depends on https://codereview.chromium.org/1218803006/ I see it landed... rebasing.
5 years, 5 months ago (2015-07-07 21:58:06 UTC) #2
arv (Not doing code reviews)
Cleanup
5 years, 5 months ago (2015-07-07 22:16:26 UTC) #3
arv (Not doing code reviews)
PTAL I'm not yet sure what is going on with eval. It creates a DYNAMIC_LOCAL. ...
5 years, 5 months ago (2015-07-07 22:19:41 UTC) #4
rossberg
LGTM modulo comments. I'm not too happy with duplicating all the tests via copy & ...
5 years, 5 months ago (2015-07-08 11:49:56 UTC) #6
arv (Not doing code reviews)
Updated tests and comments
5 years, 5 months ago (2015-07-08 13:43:31 UTC) #7
arv (Not doing code reviews)
https://codereview.chromium.org/1219853004/diff/40001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1219853004/diff/40001/test/cctest/test-parsing.cc#newcode6787 test/cctest/test-parsing.cc:6787: static const ParserFlag always_flags[] = {kNoLegacyConst}; On 2015/07/08 11:49:56, ...
5 years, 5 months ago (2015-07-08 13:43:45 UTC) #8
arv (Not doing code reviews)
I also agree that duplicating these tests is sad. One option might be to introduce ...
5 years, 5 months ago (2015-07-08 13:45:50 UTC) #9
rossberg
https://codereview.chromium.org/1219853004/diff/60001/test/mjsunit/harmony/block-let-semantics-sloppy.js File test/mjsunit/harmony/block-let-semantics-sloppy.js (right): https://codereview.chromium.org/1219853004/diff/60001/test/mjsunit/harmony/block-let-semantics-sloppy.js#newcode98 test/mjsunit/harmony/block-let-semantics-sloppy.js:98: // TODO(arv): https://code.google.com/p/v8/issues/detail?id=4284 Nit: feel free to put in ...
5 years, 5 months ago (2015-07-08 13:51:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219853004/60001
5 years, 5 months ago (2015-07-08 14:58:54 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-08 15:04:09 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 15:04:25 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3b1aabc960ea7a1107c8b6ebb8f2b4ce48e9b610
Cr-Commit-Position: refs/heads/master@{#29536}

Powered by Google App Engine
This is Rietveld 408576698