Restoring recently deleted unit tests

chrome/browser/resources/google_now/cards.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Show/hide trigger in a card.
  *
  * @typedef {{
@@ skipping 95 matching lines @@
 /**
  * Builds an object to manage notification card set.
  * @return {Object} Card set interface.
  */
 function buildCardSet() {
   var alarmPrefix = 'card-';
 
   /**
    * Creates/updates/deletes a Chrome notification.
    * @param {ChromeNotificationId} cardId Card ID.
-   * @param {?ReceivedNotification} receivedNotification Google Now card
-   *     represented as a set of parameters for showing a Chrome notification,
-   *     or null if the notification needs to be deleted.
+   * @param {(ReceivedNotification|undefined)} receivedNotification Google Now
+   *     card represented as a set of parameters for showing a Chrome
+   *     notification, or null if the notification needs to be deleted.
    * @param {function(ReceivedNotification)=} onCardShown Optional parameter
    *     called when each card is shown.
    */
   function updateNotification(cardId, receivedNotification, onCardShown) {
     console.log('cardManager.updateNotification ' + cardId + ' ' +
                 JSON.stringify(receivedNotification));
 
     if (!receivedNotification) {
       instrumented.notifications.clear(cardId, function() {});
       return;
@@ skipping 59 matching lines @@
    * @param {function(ReceivedNotification)=} onCardShown Optional parameter
    *     called when each card is shown.
    * @return {(NotificationDataEntry|undefined)} Notification data entry for
    *     this card. It's 'undefined' if the card's life is over.
    */
   function update(cardId, combinedCard, notificationGroups, onCardShown) {
     console.log('cardManager.update ' + JSON.stringify(combinedCard));
 
     chrome.alarms.clear(alarmPrefix + cardId);
     var now = Date.now();
     /** @type {?UncombinedNotification} */

[rgustafson, 2014/01/07 20:36:45]

|undefined rather than ?nullable

[vadimt, 2014/01/08 02:19:01]

Done.

-    var winningCard = null;
+    var winningCard = undefined;
     // Next moment of time when winning notification selection algotithm can
     // potentially return a different notification.
     /** @type {?number} */
     var nextEventTime = null;
 
     // Find a winning uncombined notification: a highest-priority notification
     // that needs to be shown now.
     iterateUncombinedNotifications(
         combinedCard,
         now,
@@ skipping 26 matching lines @@
         cardId, winningCard && winningCard.receivedNotification, onCardShown);
 
     if (nextEventTime) {
       // If we expect more events, create an alarm for the next one.
       chrome.alarms.create(alarmPrefix + cardId, {when: nextEventTime});
 
       // The trick with stringify/parse is to create a copy of action URLs,
       // otherwise notifications data with 2 pointers to the same object won't
       // be stored correctly to chrome.storage.
       var winningActionUrls = winningCard &&
-          (winningCard.receivedNotification.actionUrls || null) &&
+          winningCard.receivedNotification.actionUrls &&
           JSON.parse(JSON.stringify(
               winningCard.receivedNotification.actionUrls));
 
       return {
         actionUrls: winningActionUrls,
         timestamp: now,
         combinedCard: combinedCard
       };
     } else {
       // If there are no more events, we are done with this card. Note that all
@@ skipping 101 matching lines @@
             });
       });
     }
   });
 
   return {
     update: update,
     onDismissal: onDismissal
   };
 }