Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 1219823002: X87: Unify the stack layout for construct frames. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Unify the stack layout for construct frames. port 876ae425980f67f489323671f13d2314b0ce0a91 (r29292). original commit message: The stack layout was different for different ports. BUG= Committed: https://crrev.com/fb1329aa2d9e8acec495abf47e60d663a27d7491 Cr-Commit-Position: refs/heads/master@{#29412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/x87/frames-x87.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL>
5 years, 5 months ago (2015-06-30 09:19:57 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-01 11:04:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219823002/1
5 years, 5 months ago (2015-07-01 11:04:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 12:03:30 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 12:03:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb1329aa2d9e8acec495abf47e60d663a27d7491
Cr-Commit-Position: refs/heads/master@{#29412}

Powered by Google App Engine
This is Rietveld 408576698