Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1219753005: Only call finishLoad() if session actually loaded. (Closed)

Created:
5 years, 5 months ago by jrummell
Modified:
5 years, 5 months ago
Reviewers:
ddorwin
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Only call finishLoad() if session actually loaded. BUG=507736 TEST=modified EME browser tests pass (coming in https://codereview.chromium.org/1224053003/) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198532

Patch Set 1 #

Total comments: 2

Patch Set 2 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jrummell
PTAL. Very small change.
5 years, 5 months ago (2015-07-07 20:58:24 UTC) #2
ddorwin
LG. I have a suggestion. Also, we should try to have a more concrete reference ...
5 years, 5 months ago (2015-07-07 21:05:11 UTC) #3
jrummell
Updated. https://codereview.chromium.org/1219753005/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp File Source/modules/encryptedmedia/MediaKeySession.cpp (right): https://codereview.chromium.org/1219753005/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp#newcode282 Source/modules/encryptedmedia/MediaKeySession.cpp:282: result = false; On 2015/07/07 21:05:11, ddorwin wrote: ...
5 years, 5 months ago (2015-07-08 18:43:35 UTC) #4
ddorwin
lgtm Thanks.
5 years, 5 months ago (2015-07-08 19:08:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219753005/20001
5 years, 5 months ago (2015-07-08 19:12:03 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 20:18:22 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198532

Powered by Google App Engine
This is Rietveld 408576698