Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 1219753003: Change ListContainer::AppendByMoving to return a pointer to the new item (Closed)

Created:
5 years, 5 months ago by pdr.
Modified:
5 years, 5 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chrishtr, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ListContainer::AppendByMoving to return a pointer to the new item This patch changes the return value of ListContainer::AppendByMoving to return a pointer to the moved item at the new location. This was found to be a performacne win in https://codereview.chromium.org/1193433004 because accessing the last element is not free. A new test has been added to prove correctness. BUG=484943 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/3e92831524899eb6b6b3f7f61dd0f51dbd0ae7d6 Cr-Commit-Position: refs/heads/master@{#336647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M cc/base/list_container.h View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/base/list_container_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pdr.
5 years, 5 months ago (2015-06-29 20:19:58 UTC) #4
danakj
LGTM
5 years, 5 months ago (2015-06-29 20:21:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219753003/1
5 years, 5 months ago (2015-06-29 20:24:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 21:28:31 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 21:29:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e92831524899eb6b6b3f7f61dd0f51dbd0ae7d6
Cr-Commit-Position: refs/heads/master@{#336647}

Powered by Google App Engine
This is Rietveld 408576698