Issue 121973003: Merge 242646 "Pepper: FileIO holds FileSystem ref with scoped_re..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 121973003: Merge 242646 "Pepper: FileIO holds FileSystem ref with scoped_re..." (Closed)

Created:
6 years, 11 months ago by bbudge

Modified:
6 years, 11 months ago

Reviewers:
bbudge

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1750/src/

Visibility:
Public.

More Reviews

Description

Merge 242646 "Pepper: FileIO holds FileSystem ref with scoped_re..." > Pepper: FileIO holds FileSystem ref with scoped_refptr<Resource>. > > 1) Use a scoped_refptr to keep the FileSystemResource alive. > ScopedPPResource isn't safe for this purpose. > 2) Make sure that the FileIOResource always sends a close message, so > the FileIO host can unhook from the FileSystemHost before the latter is > destroyed. Due to refcounting, the destruction order is in some cases not > what we want. > > R=teravest@chromium.org > BUG=330809, 330859 > > Review URL: https://codereview.chromium.org/121813002 TBR=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243313

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -13 lines)			Patch
M	content/browser/renderer_host/pepper/pepper_file_io_host.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	ppapi/proxy/file_io_resource.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ppapi/proxy/file_io_resource.cc	View	4 chunks	+25 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r243313.

Expand Messages | Collapse Messages