Make "insertHTML" execCommand not to crash on TEXTAREA

Make "insertHTML" execCommand not to crash on TEXTAREA

This patch changes "insertHTML" execCommand on TEXTAREA not to crash when
inserted HTML containing text.

The root cause of issue 504886 is calling |plainText()| with null |Range| object
in |ReplacementFragment| constructor. This null |Range| object is comes from
|VisibleSelection::selectionFromContentsOfNode()| with HTML fragment without
text content, e.g. "<b></b>", "<span>", and so on, which returns empty
seleciton.


BUG=504886
TEST=LayoutTests/editing/inserting/insert-html-to-textarea-crash.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198037

[yosin_UTC9, 2015-06-30 04:42:06]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2015-06-30 04:42:13]

PTAL

[hajimehoshi, 2015-06-30 05:02:55]

https://codereview.chromium.org/1219723004/diff/1/Source/core/editing/Replace...
File Source/core/editing/ReplaceSelectionCommand.cpp (right):

https://codereview.chromium.org/1219723004/diff/1/Source/core/editing/Replace...
Source/core/editing/ReplaceSelectionCommand.cpp:185: String text = range ?
plainText(range.get(),
static_cast<TextIteratorBehavior>(TextIteratorEmitsOriginalText |
TextIteratorIgnoresStyleVisibility)) : emptyString();
Does this mean plainText always accept non-null range? If so, plainText should
have const Range& parameter instead of const Range*.

[yosin_UTC9, 2015-06-30 05:04:54]

https://codereview.chromium.org/1219723004/diff/1/Source/core/editing/Replace...
File Source/core/editing/ReplaceSelectionCommand.cpp (right):

https://codereview.chromium.org/1219723004/diff/1/Source/core/editing/Replace...
Source/core/editing/ReplaceSelectionCommand.cpp:185: String text = range ?
plainText(range.get(),
static_cast<TextIteratorBehavior>(TextIteratorEmitsOriginalText |
TextIteratorIgnoresStyleVisibility)) : emptyString();
On 2015/06/30 05:02:55, hajimehoshi wrote:
> Does this mean plainText always accept non-null range? If so, plainText should
> have const Range& parameter instead of const Range*.

Another patch will remove |plainText(Range*)| API for Oilpan friendly.

[hajimehoshi, 2015-06-30 05:05:45]

lgtm

[yosin_UTC9, 2015-06-30 05:21:02]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-06-30 05:21:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1219723004/1

[commit-bot: I haz the power, 2015-06-30 05:55:24]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198037