Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1219723002: Ensure mjsunit tests use dashes not underscores in flags directives. (Closed)

Created:
5 years, 5 months ago by oth
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure mjsunit tests use dashes not underscores in flags directives. BUG=chromium:505228 LOG=Y Committed: https://crrev.com/cff8c9b9339111b1b807aceacf43235b36d1a98f Cr-Commit-Position: refs/heads/master@{#29355}

Patch Set 1 #

Patch Set 2 : Remove commented code om patch set 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M test/mjsunit/declare-locally.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/elements-kind.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/math-floor-negative.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/math-floor-of-div.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/math-floor-of-div-minus-zero.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/math-floor-of-div-nosudiv.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1119.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1132.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-115452.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1199637.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-166553.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2593.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2653.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-360733.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-370384.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-747.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-arguments-gc.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-217858.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-regexp-codeflush.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/presubmit.py View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219723002/1
5 years, 5 months ago (2015-06-29 15:42:16 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 5 months ago (2015-06-29 15:42:18 UTC) #4
oth
ishell@chromium.org: Please review changes in mjsunit and tools. mstarzinger@chromium.org: Please review changes in mjsunit and ...
5 years, 5 months ago (2015-06-29 15:48:36 UTC) #6
Igor Sheludko
lgtm
5 years, 5 months ago (2015-06-29 15:56:14 UTC) #7
Michael Starzinger
LGTM. Thanks!
5 years, 5 months ago (2015-06-29 15:58:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219723002/20001
5 years, 5 months ago (2015-06-29 16:40:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-29 17:08:06 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 17:08:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cff8c9b9339111b1b807aceacf43235b36d1a98f
Cr-Commit-Position: refs/heads/master@{#29355}

Powered by Google App Engine
This is Rietveld 408576698