Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 1219713003: DevTools: [regression] compare canonical text when matching styles. (Closed)

Created:
5 years, 5 months ago by pfeldman
Modified:
5 years, 5 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [regression] compare canonical text when matching styles. BUG=505861 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198129

Patch Set 1 #

Total comments: 1

Patch Set 2 : awesome review comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -12 lines) Patch
M LayoutTests/inspector-protocol/css/css-set-style-text.html View 8 chunks +40 lines, -8 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-set-style-text-expected.txt View 1 chunk +149 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 4 chunks +45 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
pfeldman
5 years, 5 months ago (2015-06-30 16:55:25 UTC) #2
pfeldman
ping. this fixes a nasty regression in Canary. please review.
5 years, 5 months ago (2015-07-01 05:17:20 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/1219713003/diff/1/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp (right): https://codereview.chromium.org/1219713003/diff/1/Source/core/inspector/InspectorStyleSheet.cpp#newcode604 Source/core/inspector/InspectorStyleSheet.cpp:604: if (rule->type() != CSSRule::STYLE_RULE) nit RefPtr<CSSStyleRule> styleRule = ...
5 years, 5 months ago (2015-07-01 08:36:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219713003/1
5 years, 5 months ago (2015-07-01 08:36:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219713003/20001
5 years, 5 months ago (2015-07-01 09:22:30 UTC) #10
lushnikov
Great job, pfeldman.
5 years, 5 months ago (2015-07-01 09:22:59 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 10:31:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198129

Powered by Google App Engine
This is Rietveld 408576698