Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1219713002: Removed bookmark_image_service (Closed)

Created:
5 years, 5 months ago by stkhapugin
Modified:
5 years, 4 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed bookmark_image_service This class is being deprecated as is no longer used. BUG=None Committed: https://crrev.com/dcbb9850222dfe22cc4d654e858bde344672e90a Cr-Commit-Position: refs/heads/master@{#343008}

Patch Set 1 #

Patch Set 2 : pulled changes #

Patch Set 3 : fixed accidental BookmarkImageServiceFactory mention #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1456 lines) Patch
M components/enhanced_bookmarks.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D components/enhanced_bookmarks/bookmark_image_service.h View 1 chunk +0 lines, -190 lines 0 comments Download
D components/enhanced_bookmarks/bookmark_image_service.cc View 1 chunk +0 lines, -379 lines 0 comments Download
M ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
D ios/chrome/browser/enhanced_bookmarks/bookmark_image_service_factory.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ios/chrome/browser/enhanced_bookmarks/bookmark_image_service_factory.mm View 1 chunk +0 lines, -52 lines 0 comments Download
D ios/chrome/browser/enhanced_bookmarks/bookmark_image_service_ios.h View 1 chunk +0 lines, -98 lines 0 comments Download
D ios/chrome/browser/enhanced_bookmarks/bookmark_image_service_ios.js View 1 chunk +0 lines, -63 lines 0 comments Download
D ios/chrome/browser/enhanced_bookmarks/bookmark_image_service_ios.mm View 1 chunk +0 lines, -392 lines 0 comments Download
D ios/chrome/browser/enhanced_bookmarks/bookmark_image_service_ios_unittest.mm View 1 chunk +0 lines, -225 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 3 chunks +0 lines, -6 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 33 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219713002/1
5 years, 5 months ago (2015-06-29 13:05:35 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 5 months ago (2015-06-29 13:05:37 UTC) #4
stkhapugin
PTAL
5 years, 5 months ago (2015-06-29 13:06:24 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219713002/1
5 years, 5 months ago (2015-06-29 14:50:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-29 15:46:52 UTC) #10
noyau (Ping after 24h)
Note that you can also remove the image store as well (Feel free to do ...
5 years, 5 months ago (2015-06-30 07:39:29 UTC) #11
noyau (Ping after 24h)
lgtm
5 years, 5 months ago (2015-06-30 07:39:50 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1219713002/1
5 years, 4 months ago (2015-08-03 08:21:10 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/80357) ios_dbg_simulator_ninja on ...
5 years, 4 months ago (2015-08-03 08:22:47 UTC) #16
stkhapugin
+sdefresne@chromium.org as owner PTAL
5 years, 4 months ago (2015-08-12 10:23:51 UTC) #18
sdefresne
rubberstamp lgtm
5 years, 4 months ago (2015-08-12 10:24:57 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1219713002/20001
5 years, 4 months ago (2015-08-12 10:25:41 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/55756)
5 years, 4 months ago (2015-08-12 10:33:48 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1219713002/20001
5 years, 4 months ago (2015-08-12 12:14:48 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/55767)
5 years, 4 months ago (2015-08-12 12:22:39 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1219713002/40001
5 years, 4 months ago (2015-08-12 12:25:46 UTC) #31
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-12 13:21:07 UTC) #32
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 13:21:46 UTC) #33
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/dcbb9850222dfe22cc4d654e858bde344672e90a
Cr-Commit-Position: refs/heads/master@{#343008}

Powered by Google App Engine
This is Rietveld 408576698