Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1219693003: A couple of other "stack overflow" vs. "has_pending_exception()" issues in debugger fixed. (Closed)

Created:
5 years, 5 months ago by Igor Sheludko
Modified:
5 years, 5 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

A couple of other "stack overflow" vs. "has_pending_exception()" issues in debugger fixed. BUG=chromium:505007 LOG=N Committed: https://crrev.com/b8cce79f41a26000164800d7c640e3b3e6a0850b Cr-Commit-Position: refs/heads/master@{#29369}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/runtime/runtime-debug.cc View 2 chunks +9 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-505007-1.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-505007-2.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Igor Sheludko
PTAL
5 years, 5 months ago (2015-06-29 15:35:11 UTC) #3
Yang
On 2015/06/29 15:35:11, Igor Sheludko wrote: > PTAL LGTM, thanks!
5 years, 5 months ago (2015-06-30 06:41:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219693003/20001
5 years, 5 months ago (2015-06-30 08:28:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-06-30 08:30:11 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b8cce79f41a26000164800d7c640e3b3e6a0850b Cr-Commit-Position: refs/heads/master@{#29369}
5 years, 5 months ago (2015-06-30 08:30:24 UTC) #8
Michael Achenbach
5 years, 5 months ago (2015-07-20 09:01:14 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698