Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2808)

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java

Issue 1219683014: Added Generic Parameterized Testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tommy's LGTM Nit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java
diff --git a/base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java b/base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java
index 7c7cdc9f8b3ebe542302626f7b92492afe6b8e77..9ce432b7f9ea049ec3973eb52e63e592f4f23035 100644
--- a/base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java
+++ b/base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java
@@ -7,6 +7,14 @@ package org.chromium.base.test;
import android.app.Activity;
import android.test.ActivityInstrumentationTestCase2;
+import org.chromium.base.test.util.parameter.BaseParameter;
+import org.chromium.base.test.util.parameter.Parameter;
+import org.chromium.base.test.util.parameter.Parameterizable;
+import org.chromium.base.test.util.parameter.parameters.MethodParameter;
+
+import java.util.HashMap;
+import java.util.Map;
+
/**
* Base class for all Activity-based Instrumentation tests.
*
@@ -15,10 +23,46 @@ import android.test.ActivityInstrumentationTestCase2;
* @param <T> The Activity type.
*/
public class BaseActivityInstrumentationTestCase<T extends Activity>
- extends ActivityInstrumentationTestCase2<T> {
+ extends ActivityInstrumentationTestCase2<T> implements Parameterizable {
+ private Parameter.Reader mParameterReader;
+ /**
+ * Creates a instance for running tests against an Activity of the given class.
+ *
+ * @param activityClass The type of activity that will be tested.
+ */
public BaseActivityInstrumentationTestCase(Class<T> activityClass) {
super(activityClass);
}
+ /**
+ * Creates the list of available parameters that inherited classes can use.
+ *
+ * @return a list of {@link BaseParameter} objects to set as the available parameters.
+ */
+ public Map<String, BaseParameter> getAvailableParameters() {
+ Map<String, BaseParameter> parameters = new HashMap<>();
+ parameters.put(MethodParameter.PARAMETER_TAG, new MethodParameter(getParameterReader()));
+ return parameters;
+ }
+
+ /**
+ * Setter method for {@link Parameter.Reader}.
+ *
+ * @param parameterReader the {@link Parameter.Reader} to set.
+ */
+ public void setParameterReader(Parameter.Reader parameterReader) {
+ mParameterReader = parameterReader;
+ }
+
+ /**
+ * Getter method for {@link Parameter.Reader} object to be used by test cases reading the
+ * parameter.
+ *
+ * @return the {@link Parameter.Reader} for the current {@link
+ * org.chromium.base.test.util.parameter.ParameterizedTest} being run.
+ */
+ protected Parameter.Reader getParameterReader() {
+ return mParameterReader;
+ }
}
« no previous file with comments | « no previous file | base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698