Make ContentStreamParser members private, fix constructor

Make ContentStreamParser members private, fix constructor

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/5b4f57cdc0a279bd9b8e03b8f5714b9d39e642a8

[Tom Sepez, 2015-06-29 22:55:43]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-06-29 22:55:43]

Lei, whenever you're back.

[Lei Zhang, 2015-07-15 01:48:32]

lgtm

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp (right):

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:23: CPDF_AllStates* pStates, int
level)
nit: put |level| on the next line.

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:34: m_pLastTextObject(NULL),
nit: NULL -> nullptr here and below

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:80: int i = 0;
nit: declare |i| in the for-loop.

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/pageint.h (right):

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/pageint.h:142: CPDF_AllStates*	GetCurStates() const {
return m_pCurStates.get(); }
nit: remove the tab

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/pageint.h:272: CPDF_PageObjects* m_pObjectList;
nit: use 1 space, rather than aligning some variables

[Tom Sepez, 2015-07-15 23:54:42]

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp (right):

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:23: CPDF_AllStates* pStates, int
level)
On 2015/07/15 01:48:31, Lei Zhang wrote:
> nit: put |level| on the next line.

Done.

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:34: m_pLastTextObject(NULL),
On 2015/07/15 01:48:31, Lei Zhang wrote:
> nit: NULL -> nullptr here and below

Done.

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:80: int i = 0;
On 2015/07/15 01:48:31, Lei Zhang wrote:
> nit: declare |i| in the for-loop.

Done. Aslo ++i while I'm at it.

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/pageint.h (right):

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/pageint.h:142: CPDF_AllStates*	GetCurStates() const {
return m_pCurStates.get(); }
On 2015/07/15 01:48:32, Lei Zhang wrote:
> nit: remove the tab
Done.

https://codereview.chromium.org/1219683007/diff/10005/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/pageint.h:272: CPDF_PageObjects* m_pObjectList;
On 2015/07/15 01:48:32, Lei Zhang wrote:
> nit: use 1 space, rather than aligning some variables

Done.

[Tom Sepez, 2015-07-15 23:54:54]

Committed patchset #3 (id:30001) manually as
5b4f57cdc0a279bd9b8e03b8f5714b9d39e642a8 (presubmit successful).