Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1219663009: [strong] Add tests for loading from super, loading with access checks (Closed)

Created:
5 years, 5 months ago by conradw
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Add tests for loading from super, loading with access checks BUG=v8:3956 LOG=N Committed: https://crrev.com/37bf0481de79b6e86f1b470c880cab4b71eda8bc Cr-Commit-Position: refs/heads/master@{#29448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -1 line) Patch
M test/cctest/test-api.cc View 1 chunk +158 lines, -0 lines 0 comments Download
M test/mjsunit/strong/load-builtins.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/strong/load-super.js View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
conradw
PTAL
5 years, 5 months ago (2015-07-02 14:55:24 UTC) #2
rossberg
lgtm
5 years, 5 months ago (2015-07-02 15:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219663009/1
5 years, 5 months ago (2015-07-02 15:21:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 15:23:46 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 15:23:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37bf0481de79b6e86f1b470c880cab4b71eda8bc
Cr-Commit-Position: refs/heads/master@{#29448}

Powered by Google App Engine
This is Rietveld 408576698