Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: src/promise.js

Issue 1219623005: [es6] Make sure we do not invoke setter when calling Promise.all (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/promise.js
diff --git a/src/promise.js b/src/promise.js
index 2634fde0bb8e8c9b5f0e5eb52be5dd7fde566125..ca3692cf6c083623a20d46fdd41fa6377c547ce1 100644
--- a/src/promise.js
+++ b/src/promise.js
@@ -189,11 +189,11 @@ function PromiseDeferred() {
reject: function(r) { PromiseReject(promise, r) }
};
} else {
- var result = {};
+ var result = {__proto__: null};
rossberg 2015/06/29 16:05:53 This is visible in the public API (even if .defer
arv (Not doing code reviews) 2015/06/29 16:44:59 I'm fine doing that. Where is the spec for this p
result.promise = new this(function(resolve, reject) {
result.resolve = resolve;
result.reject = reject;
- })
+ });
return result;
}
}
« no previous file with comments | « no previous file | test/mjsunit/es6/promise-internal-setter.js » ('j') | test/mjsunit/es6/promise-internal-setter.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698