Chromium Code Reviews Chromium Code Reviews
Issue 1219623005:
[es6] Make sure we do not invoke setter when calling Promise.all (Closed)
Base URL: https://chromium.googlesource.com/v8/v8.git@master| OLD | NEW |
|---|---|
| 1 // Copyright 2015 the V8 project authors. All rights reserved. | 1 // Copyright 2015 the V8 project authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 // | 4 |
| 5 // Flags: --harmony-rest-parameters | |
| 6 'use strict'; | 5 'use strict'; |
| 7 | 6 |
| 8 var _bad = "this should fail!"; | 7 Object.defineProperty(Object.prototype, 'promise', { |
| 9 ({ | 8 set(x) { |
|
rossberg
2015/06/29 16:05:53
Nit: I supposed this can be abbreviated to {set: a
arv (Not doing code reviews)
2015/06/29 16:44:59
Done.
| |
| 10 get bad() { return _bad; }, | 9 assertUnreachable(); |
| 11 set bad(...args) { _bad = args[0]; } | 10 } |
| 12 }); | 11 }); |
| 12 | |
| 13 class P extends Promise {} | |
| 14 P.all([Promise.resolve('ok')]); | |
|
rossberg
2015/06/29 16:05:53
Can you add a case for .race and .defer as well?
I
arv (Not doing code reviews)
2015/06/29 16:44:59
It needs to be a function that has a static resolv
| |
| OLD | NEW |
