Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1219613002: Always enable lazy sweeping. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Always enable lazy sweeping. This turns on lazy sweeping for enable_oilpan=0. Lazy/incremental sweeping reduces GC pause times by having the garbage collector perform its marking and processing of live objects together with a minimal amount of sweeping of finalizable objects before returning. The remaining heap regions to be swept up and finalized are then handled incrementally as part of heap allocation requests. Amortizing that sweeping cost rather than taking a longer GC "stop the world" pause in one go. Lazy sweeping is enabled with Oilpan always on (enable_oilpan=1); this extends it to also be for the Oilpan GCs that run on trunk (where enable_oilpan=0). R=haraken BUG=480837 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/build/features.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
haraken
Let's try this now. LGTM.
5 years, 5 months ago (2015-06-30 08:01:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219613002/1
5 years, 5 months ago (2015-06-30 19:06:27 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 20:14:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198095

Powered by Google App Engine
This is Rietveld 408576698