Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1219603002: Revert of content: Enable native GpuMemoryBuffers by default on MacOSX. (Closed)

Created:
5 years, 5 months ago by pdr.
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of content: Enable native GpuMemoryBuffers by default on MacOSX. (patchset #6 id:100001 of https://codereview.chromium.org/1165823003/) Reason for revert: This change caused many mac layouttests to fail, see: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/107/layout-test-results/results.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Foverflow%2Fborder-radius-clipping.html Reverting locally fixed this issue. Original issue's description: > content: Enable native GpuMemoryBuffers by default on MacOSX. > > This eliminates the need for texture uploads to initialize > tile textures on MacOSX. > > BUG=486922 > > Committed: https://crrev.com/ab11fd094eb5eb8913a87b9f12497cab0725c73a > Cr-Commit-Position: refs/heads/master@{#336502} TBR=avi@chromium.org,ccameron@chromium.org,piman@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=486922 Committed: https://crrev.com/1f9990d034b73856aaea66f8fc93ac4af9bd1943 Cr-Commit-Position: refs/heads/master@{#336506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M content/child/child_thread_impl_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pdr.
Created Revert of content: Enable native GpuMemoryBuffers by default on MacOSX.
5 years, 5 months ago (2015-06-28 03:12:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219603002/1
5 years, 5 months ago (2015-06-28 03:12:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-28 03:13:15 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-06-28 03:14:10 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f9990d034b73856aaea66f8fc93ac4af9bd1943
Cr-Commit-Position: refs/heads/master@{#336506}

Powered by Google App Engine
This is Rietveld 408576698