Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1219563002: Fix cluster-fuzz found regression in d8 Workers. (Closed)

Created:
5 years, 6 months ago by binji
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix cluster-fuzz found regression in d8 Workers. Dumb typo introduced in refs/heads/master@{#29306}. I thought I was turning on report_exceptions in Shell::ExecuteString, but instead I turned on print_result (which assumes an interactive debugger and a HandleScope for the utility_context_). BUG=chromium:504727, chromium:504728 R=mstarzinger@chromium.org LOG=n Committed: https://crrev.com/93c43523eac8204ae84839a0470b3ee3fe52b3e2 Cr-Commit-Position: refs/heads/master@{#29350}

Patch Set 1 #

Patch Set 2 : add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-504727.js View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
5 years, 6 months ago (2015-06-26 23:38:47 UTC) #1
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-06-29 09:38:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219563002/20001
5 years, 5 months ago (2015-06-29 15:19:43 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-29 15:48:36 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 15:48:51 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93c43523eac8204ae84839a0470b3ee3fe52b3e2
Cr-Commit-Position: refs/heads/master@{#29350}

Powered by Google App Engine
This is Rietveld 408576698