Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1219553003: Clean up SelectionController with namespace instead of static (Closed)

Created:
5 years, 6 months ago by Miyoung Shin(c)
Modified:
5 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up SelectionController with namespace instead of static BUG=483376 TEST=n/a; No behavior changes. R=yosin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -168 lines) Patch
M Source/core/editing/SelectionController.cpp View 5 chunks +172 lines, -168 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Miyoung Shin(c)
PTAL
5 years, 6 months ago (2015-06-26 21:35:07 UTC) #1
yosin_UTC9
lgtm Thanks for cleanup!
5 years, 5 months ago (2015-06-29 01:13:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219553003/1
5 years, 5 months ago (2015-06-29 01:13:15 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 02:20:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197954

Powered by Google App Engine
This is Rietveld 408576698