Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2241)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 1219503003: Remove incrementalAnalysisCache and fix more tests (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/context/context_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index 071165804559efe37cacb3808742f2603494cce5..52a8b10c784eb2f98d00603297d371245ea7b2a2 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -157,11 +157,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
new HashMap<Source, ChangeNoticeImpl>();
/**
- * Cached information used in incremental analysis or `null` if none.
- */
- IncrementalAnalysisCache _incrementalAnalysisCache;
-
- /**
* The [TypeProvider] for this context, `null` if not yet created.
*/
TypeProvider _typeProvider;
@@ -424,14 +419,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
return statistics;
}
- IncrementalAnalysisCache get test_incrementalAnalysisCache {
- return _incrementalAnalysisCache;
- }
-
- set test_incrementalAnalysisCache(IncrementalAnalysisCache value) {
- _incrementalAnalysisCache = value;
- }
-
List<Source> get test_priorityOrder => _priorityOrder;
@override
@@ -953,8 +940,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
bool changed = newContents != originalContents;
if (newContents != null) {
if (newContents != originalContents) {
- _incrementalAnalysisCache =
- IncrementalAnalysisCache.clear(_incrementalAnalysisCache, source);
if (!analysisOptions.incremental ||
!_tryPoorMansIncrementalResolution(source, newContents)) {
_sourceChanged(source);
@@ -965,8 +950,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
entry.modificationTime = _contentCache.getModificationStamp(source);
}
} else if (originalContents != null) {
- _incrementalAnalysisCache =
- IncrementalAnalysisCache.clear(_incrementalAnalysisCache, source);
changed = newContents != originalContents;
// We are removing the overlay for the file, check if the file's
// contents is the same as it was in the overlay.
@@ -1424,8 +1407,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
}
} else if (originalContents != null) {
- _incrementalAnalysisCache =
- IncrementalAnalysisCache.clear(_incrementalAnalysisCache, source);
_sourceChanged(source);
changed = true;
}
« no previous file with comments | « no previous file | pkg/analyzer/test/src/context/context_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698