Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1219493003: Cleanup sky/sdk/examples (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Cleanup sky/sdk/examples * Remove all the DOM-based examples except for the old stocks app * Rename stocks2 to stocks * Promote hello_widgets.dart to a top-level hello_world example TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2828cf2563351240d11a3784dfaa68dfa988b7bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -31055 lines) Patch
D sky/sdk/example/color/color-chooser.sky View 1 chunk +0 lines, -96 lines 0 comments Download
D sky/sdk/example/color/color-wheel.png View Binary file 0 comments Download
D sky/sdk/example/color/pubspec.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/sdk/example/hello_world/hello_world.dart View 1 chunk +0 lines, -11 lines 0 comments Download
A + sky/sdk/example/hello_world/lib/main.dart View 1 chunk +1 line, -1 line 0 comments Download
D sky/sdk/example/hello_world/main.sky View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/sdk/example/hello_world/pubspec.yaml View 1 chunk +5 lines, -1 line 0 comments Download
D sky/sdk/example/lib/solid_color_box.dart View 1 chunk +0 lines, -51 lines 0 comments Download
A + sky/sdk/example/old/stocks/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_0.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_1.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_10.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_11.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_12.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_13.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_14.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_15.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_16.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_17.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_18.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_19.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_2.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_20.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_21.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_22.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_23.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_24.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_25.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_26.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_27.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_28.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_29.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_3.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_4.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_5.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_6.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_7.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_8.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/data/stock_data_9.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/lib/stock_app.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/lib/stock_arrow.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/lib/stock_data.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/lib/stock_list.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/lib/stock_menu.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/lib/stock_row.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/main.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/old/stocks/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/sdk/example/raw/launcher.dart View 1 chunk +0 lines, -57 lines 0 comments Download
M sky/sdk/example/rendering/interactive_flex.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/rendering/justify_content.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/rendering/render_paragraph.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/example/rendering/solid_color_box.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/sdk/example/rendering/spinning_flex.dart View 1 chunk +1 line, -1 line 0 comments Download
D sky/sdk/example/stocks/README.md View 1 chunk +0 lines, -31 lines 0 comments Download
A + sky/sdk/example/stocks/lib/main.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/sdk/example/stocks/lib/stock_app.dart View 1 chunk +0 lines, -225 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_arrow.dart View 1 chunk +55 lines, -73 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_data.dart View 2 chunks +2 lines, -1 line 0 comments Download
A + sky/sdk/example/stocks/lib/stock_home.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_list.dart View 1 chunk +15 lines, -7 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_menu.dart View 1 chunk +21 lines, -22 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_row.dart View 1 chunk +39 lines, -48 lines 0 comments Download
A + sky/sdk/example/stocks/lib/stock_settings.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/stocks/lib/stock_types.dart View 1 chunk +1 line, -2 lines 0 comments Download
D sky/sdk/example/stocks/main.sky View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/sdk/example/stocks/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
D sky/sdk/example/stocks2/README.md View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_0.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_1.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_10.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_11.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_12.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_13.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_14.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_15.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_16.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_17.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_18.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_19.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_2.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_20.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_21.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_22.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_23.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_24.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_25.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_26.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_27.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_28.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_29.json View 1 chunk +0 lines, -632 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_3.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_4.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_5.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_6.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_7.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_8.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/data/stock_data_9.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/stocks2/lib/stock_app.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D sky/sdk/example/stocks2/lib/stock_arrow.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D sky/sdk/example/stocks2/lib/stock_data.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/sdk/example/stocks2/lib/stock_home.dart View 1 chunk +0 lines, -221 lines 0 comments Download
D sky/sdk/example/stocks2/lib/stock_list.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/sdk/example/stocks2/lib/stock_menu.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D sky/sdk/example/stocks2/lib/stock_row.dart View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/sdk/example/stocks2/lib/stock_settings.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D sky/sdk/example/stocks2/lib/stock_types.dart View 1 chunk +0 lines, -1 line 0 comments Download
D sky/sdk/example/stocks2/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/sdk/example/widgets/hello_widgets.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/sdk/example/widgets/spinning_mixed.dart View 2 chunks +1 line, -4 lines 0 comments Download
M sky/sdk/home.dart View 1 chunk +1 line, -6 lines 0 comments Download
M sky/tests/examples/stocks.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-27 07:00:05 UTC) #1
abarth-chromium
5 years, 6 months ago (2015-06-27 07:00:24 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2828cf2563351240d11a3784dfaa68dfa988b7bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698