Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1219463003: Dissect and clean up instances of color parsing in CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1219463003: Dissect and clean up instances of color parsing in CSSPropertyParser (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update handling of 'grey' in fast-path color parser. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/Source/core/css/parser/CSSParserFastPaths.cpp b/Source/core/css/parser/CSSParserFastPaths.cpp

index 5acbbab07b0db11e5b05c88526471319eb90af19..1605e16ccaa9e4e15cfc124d6517e8ba77104726 100644

--- a/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -434,7 +434,7 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSParserFastPaths::parseColor(const String& st

CSSParserString cssString;

cssString.init(string);

CSSValueID valueID = cssValueKeywordID(cssString);

- if (valueID == CSSValueWebkitText || valueID == CSSValueCurrentcolor

+ if (valueID == CSSValueWebkitText || valueID == CSSValueCurrentcolor || valueID == CSSValueGrey

|| (valueID >= CSSValueAqua && valueID <= CSSValueWindowtext) || valueID == CSSValueMenu

|| (quirksMode && valueID >= CSSValueWebkitFocusRingColor && valueID < CSSValueWebkitText))

return cssValuePool().createIdentifierValue(valueID);

« no previous file with comments | « no previous file | Source/core/css/parser/CSSPropertyParser.h » ('j') | no next file with comments »