editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/SourceFileElementImpl.java - Issue 12194031: open dart files in packages directory as read only, dartbug.com/8101

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/SourceFileElementImpl.java

Issue 12194031: open dart files in packages directory as read only, dartbug.com/8101 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/SourceFileElementImpl.java

===================================================================

--- editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/SourceFileElementImpl.java (revision 18051)

+++ editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/SourceFileElementImpl.java (working copy)

@@ -15,6 +15,7 @@

import com.google.dart.compiler.DartSource;

import com.google.dart.compiler.util.DartSourceString;

+import com.google.dart.tools.core.DartCore;

import com.google.dart.tools.core.buffer.Buffer;

import com.google.dart.tools.core.internal.buffer.DocumentAdapter;

import com.google.dart.tools.core.internal.util.CharOperation;

@@ -205,7 +206,7 @@

@Override

public boolean isReadOnly() {

- return file.isReadOnly();

+ return file.isReadOnly() || DartCore.isPackagesResource(file);

}

@Override