cc: Rasterize cheap tiles immediately

cc/worker_pool.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/worker_pool.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
+#include "base/debug/trace_event.h"
 #include "base/stl_util.h"
 #include "base/stringprintf.h"
 
 #if defined(OS_ANDROID)
 // TODO(epenner): Move thread priorities to base. (crbug.com/170549)
 #include <sys/resource.h>
 #endif
 
 namespace cc {
 
 namespace {
 
 class WorkerPoolTaskImpl : public internal::WorkerPoolTask {
  public:
   WorkerPoolTaskImpl(const WorkerPool::Callback& task,
                      const base::Closure& reply)
       : internal::WorkerPoolTask(reply),
         task_(task) {}
 
+  virtual void WillRunOnThread(base::Thread* thread) OVERRIDE {}
+
   virtual void Run(RenderingStats* rendering_stats) OVERRIDE {
     task_.Run(rendering_stats);
     base::subtle::Release_Store(&completed_, 1);
   }
 
  private:
   WorkerPool::Callback task_;
 };
 
 const char* kWorkerThreadNamePrefix = "Compositor";
 
 #if defined(OS_ANDROID)
 const int kNumPendingTasksPerWorker = 8;
 #else
 const int kNumPendingTasksPerWorker = 40;
 #endif
 
 const int kCheckForCompletedTasksDelayMs = 6;
 
+// Limits for the total number of cheap tasks we are allowed to perform
+// during a single frame and the time spent running those tasks.
+// TODO(skyostil): Determine these limits more dynamically.
+const int kMaxCheapTaskCount = 6;
+const int kMaxCheapTaskMs = kCheckForCompletedTasksDelayMs;
+
 }  // namespace
 
 namespace internal {
 
 WorkerPoolTask::WorkerPoolTask(const base::Closure& reply) : reply_(reply) {
   base::subtle::Acquire_Store(&completed_, 0);
 }
 
 WorkerPoolTask::~WorkerPoolTask() {
 }
@@ skipping 30 matching lines @@
   // Complete all pending tasks. The Stop() call above guarantees that
   // all tasks have finished running.
   while (!pending_tasks_.empty())
     OnTaskCompleted();
 }
 
 void WorkerPool::Worker::PostTask(scoped_ptr<internal::WorkerPoolTask> task) {
   RenderingStats* stats =
       record_rendering_stats_ ? rendering_stats_.get() : NULL;
 
+  task->WillRunOnThread(this);
   worker_pool_->WillPostTask();

[reveman, 2013/02/20 04:33:41]

Lets remove WorkerPool::WillPostTask() and do this work in the new
WorkerPool::PostTask() function instead. 

 
   message_loop_proxy()->PostTask(
       FROM_HERE,
       base::Bind(&Worker::RunTask,
                  base::Unretained(task.get()),
                  base::Unretained(worker_pool_),
                  base::Unretained(stats)));
 
   pending_tasks_.push_back(task.Pass());
 }
@@ skipping 35 matching lines @@
   }
 }
 
 WorkerPool::WorkerPool(WorkerPoolClient* client, size_t num_threads)
     : client_(client),
       origin_loop_(base::MessageLoopProxy::current()),
       weak_ptr_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
       workers_need_sorting_(false),
       pending_task_count_(0),
       shutdown_(false),
-      check_for_completed_tasks_pending_(false),
       idle_callback_(
-          base::Bind(&WorkerPool::OnIdle, weak_ptr_factory_.GetWeakPtr())) {
+          base::Bind(&WorkerPool::OnIdle, weak_ptr_factory_.GetWeakPtr())),
+      cheap_task_callback_(
+          base::Bind(&WorkerPool::RunCheapTasks,
+                     weak_ptr_factory_.GetWeakPtr())),
+      run_cheap_tasks_pending_(false) {
   const std::string thread_name_prefix = kWorkerThreadNamePrefix;
   while (workers_.size() < num_threads) {
     int thread_number = workers_.size() + 1;
     workers_.push_back(new Worker(
         this,
         thread_name_prefix + StringPrintf("Worker%d", thread_number).c_str()));
   }
   base::subtle::Acquire_Store(&pending_task_count_, 0);
 }
 
 WorkerPool::~WorkerPool() {
   Shutdown();
   STLDeleteElements(&workers_);
   // Cancel all pending callbacks.
   weak_ptr_factory_.InvalidateWeakPtrs();
   DCHECK_EQ(base::subtle::Acquire_Load(&pending_task_count_), 0);
 }
 
 void WorkerPool::Shutdown() {
   DCHECK(!shutdown_);
   shutdown_ = true;
 
+  if (run_cheap_tasks_pending_)
+    RunCheapTasks();
+
   for (WorkerVector::iterator it = workers_.begin();
        it != workers_.end(); it++) {
     Worker* worker = *it;
     worker->StopAfterCompletingAllPendingTasks();
   }
 }
 
 void WorkerPool::PostTaskAndReply(
     const Callback& task, const base::Closure& reply) {
-  Worker* worker = GetWorkerForNextTask();
-
-  worker->PostTask(
+  PostTask(
       make_scoped_ptr(new WorkerPoolTaskImpl(
                           task,
-                          reply)).PassAs<internal::WorkerPoolTask>());
+                          reply)).PassAs<internal::WorkerPoolTask>(),
+                      false);
 }
 
 bool WorkerPool::IsBusy() {
   Worker* worker = GetWorkerForNextTask();
 
   return worker->num_pending_tasks() >= kNumPendingTasksPerWorker;
 }
 
 void WorkerPool::SetRecordRenderingStats(bool record_rendering_stats) {
+  if (record_rendering_stats)
+    cheap_rendering_stats_.reset(new RenderingStats);
+  else
+    cheap_rendering_stats_.reset();
+
   for (WorkerVector::iterator it = workers_.begin();
        it != workers_.end(); ++it) {
     Worker* worker = *it;
     worker->set_record_rendering_stats(record_rendering_stats);
   }
 }
 
 void WorkerPool::GetRenderingStats(RenderingStats* stats) {
   stats->totalRasterizeTime = base::TimeDelta();
   stats->totalRasterizeTimeForNowBinsOnPendingTree = base::TimeDelta();
   stats->totalPixelsRasterized = 0;
   stats->totalDeferredImageDecodeCount = 0;
   stats->totalDeferredImageDecodeTime = base::TimeDelta();
+  if (cheap_rendering_stats_) {
+    stats->totalRasterizeTime +=
+        cheap_rendering_stats_->totalRasterizeTime;
+    stats->totalPixelsRasterized +=
+        cheap_rendering_stats_->totalPixelsRasterized;
+    stats->totalDeferredImageDecodeCount +=
+        cheap_rendering_stats_->totalDeferredImageDecodeCount;
+    stats->totalDeferredImageDecodeTime +=
+        cheap_rendering_stats_->totalDeferredImageDecodeTime;
+  }
   for (WorkerVector::iterator it = workers_.begin();
        it != workers_.end(); ++it) {
     Worker* worker = *it;
     CHECK(worker->rendering_stats());
     stats->totalRasterizeTime +=
         worker->rendering_stats()->totalRasterizeTime;
     stats->totalRasterizeTimeForNowBinsOnPendingTree +=
         worker->rendering_stats()->totalRasterizeTimeForNowBinsOnPendingTree;
     stats->totalPixelsRasterized +=
         worker->rendering_stats()->totalPixelsRasterized;
     stats->totalDeferredImageDecodeCount +=
         worker->rendering_stats()->totalDeferredImageDecodeCount;
     stats->totalDeferredImageDecodeTime +=
         worker->rendering_stats()->totalDeferredImageDecodeTime;
   }
 }
 
 WorkerPool::Worker* WorkerPool::GetWorkerForNextTask() {
   CHECK(!shutdown_);
   SortWorkersIfNeeded();
   return workers_.front();
 }
 
 void WorkerPool::ScheduleCheckForCompletedTasks() {
-  if (check_for_completed_tasks_pending_)
+  if (!check_for_completed_tasks_deadline_.is_null())
     return;
 
   check_for_completed_tasks_callback_.Reset(
       base::Bind(&WorkerPool::CheckForCompletedTasks,
                  weak_ptr_factory_.GetWeakPtr()));
+  base::TimeDelta delay =
+      base::TimeDelta::FromMilliseconds(kCheckForCompletedTasksDelayMs);
+  check_for_completed_tasks_deadline_ = base::TimeTicks::Now() + delay;
   origin_loop_->PostDelayedTask(
       FROM_HERE,
       check_for_completed_tasks_callback_.callback(),
-      base::TimeDelta::FromMilliseconds(kCheckForCompletedTasksDelayMs));
-  check_for_completed_tasks_pending_ = true;
+      delay);
 }
 
 void WorkerPool::WillPostTask() {
   base::subtle::Barrier_AtomicIncrement(&pending_task_count_, 1);
   ScheduleCheckForCompletedTasks();
   workers_need_sorting_ = true;
 }
 
 void WorkerPool::OnWorkCompletedOnWorkerThread() {
   // Post idle handler task when pool work count reaches 0.
   if (base::subtle::Barrier_AtomicIncrement(&pending_task_count_, -1) == 0) {
     origin_loop_->PostTask(FROM_HERE, idle_callback_);
   }
 }
 
 void WorkerPool::OnIdle() {
-  if (base::subtle::Acquire_Load(&pending_task_count_) == 0) {
+  if (base::subtle::Acquire_Load(&pending_task_count_) == 0 &&
+      pending_cheap_tasks_.empty()) {
     check_for_completed_tasks_callback_.Cancel();
     CheckForCompletedTasks();
   }
 }
 
 void WorkerPool::CheckForCompletedTasks() {
-  check_for_completed_tasks_pending_ = false;
+  TRACE_EVENT0("cc", "WorkerPool::CheckForCompletedTasks");
+  check_for_completed_tasks_deadline_ = base::TimeTicks();
+
+  while (completed_cheap_tasks_.size()) {
+    scoped_ptr<internal::WorkerPoolTask> task =
+        completed_cheap_tasks_.take_front();
+    task->DidComplete();
+  }
 
   for (WorkerVector::iterator it = workers_.begin();
        it != workers_.end(); it++) {
     Worker* worker = *it;
     worker->CheckForCompletedTasks();
   }
 
   client_->DidFinishDispatchingWorkerPoolCompletionCallbacks();
 
   for (WorkerVector::iterator it = workers_.begin();
@@ skipping 11 matching lines @@
 }
 
 void WorkerPool::SortWorkersIfNeeded() {
   if (!workers_need_sorting_)
     return;
 
   std::sort(workers_.begin(), workers_.end(), NumPendingTasksComparator());
   workers_need_sorting_ = false;
 }
 
+void WorkerPool::PostTask(
+    scoped_ptr<internal::WorkerPoolTask> task, bool is_cheap) {
+  if (is_cheap && CanPostCheapTask()) {
+    PostCheapTask(task.Pass());
+  } else {
+    Worker* worker = GetWorkerForNextTask();
+    worker->PostTask(task.Pass());
+  }
+}
+
+bool WorkerPool::CanPostCheapTask() const {
+  return pending_cheap_tasks_.size() < kMaxCheapTaskCount;
+}
+
+void WorkerPool::PostCheapTask(scoped_ptr<internal::WorkerPoolTask> task) {
+  DCHECK(CanPostCheapTask());
+  pending_cheap_tasks_.push_back(task.Pass());
+  ScheduleRunCheapTasks();
+  ScheduleCheckForCompletedTasks();

[reveman, 2013/02/20 04:33:41]

move ScheduleCheckForCompletedTasks() call to PostTask() after removing
WillPostTask.

you can remove PostCheapTask() completely and fold all this into PostTask() if
you like.

+}
+
+void WorkerPool::ScheduleRunCheapTasks() {
+  if (run_cheap_tasks_pending_)
+    return;
+  origin_loop_->PostTask(FROM_HERE, cheap_task_callback_);
+  run_cheap_tasks_pending_ = true;
+}
+
+void WorkerPool::RunCheapTasks() {
+  TRACE_EVENT0("cc", "WorkerPool::RunCheapTasks");
+  DCHECK(run_cheap_tasks_pending_);
+
+  // Run as many cheap tasks as we can within the time limit.
+  base::TimeTicks deadline = base::TimeTicks::Now() +
+      base::TimeDelta::FromMilliseconds(kMaxCheapTaskMs);
+  while (pending_cheap_tasks_.size()) {
+    scoped_ptr<internal::WorkerPoolTask> task =
+        pending_cheap_tasks_.take_front();
+    task->Run(cheap_rendering_stats_.get());
+    completed_cheap_tasks_.push_back(task.Pass());
+
+    if (!check_for_completed_tasks_deadline_.is_null() &&
+        base::TimeTicks::Now() >= check_for_completed_tasks_deadline_) {
+      TRACE_EVENT_INSTANT0("cc", "WorkerPool::RunCheapTasks check deadline");
+      CheckForCompletedTasks();
+    }
+    if (base::TimeTicks::Now() >= deadline) {
+      TRACE_EVENT_INSTANT0("cc", "WorkerPool::RunCheapTasks out of time");
+      break;
+    }
+  }
+
+  // Defer remaining tasks to worker threads.
+  while (pending_cheap_tasks_.size()) {
+    scoped_ptr<internal::WorkerPoolTask> task =
+        pending_cheap_tasks_.take_front();
+    Worker* worker = GetWorkerForNextTask();
+    worker->PostTask(task.Pass());

[reveman, 2013/02/20 04:33:41]

PostTask(task, false) here instead.

+  }
+  run_cheap_tasks_pending_ = false;
+}
+
 }  // namespace cc