cc: Rasterize cheap tiles immediately

cc/worker_pool.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/worker_pool.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
+#include "base/debug/trace_event.h"
 #include "base/stl_util.h"
 #include "base/stringprintf.h"
 
 #if defined(OS_ANDROID)
 // TODO(epenner): Move thread priorities to base. (crbug.com/170549)
 #include <sys/resource.h>
 #endif
 
 namespace cc {
 
 namespace {
 
 class WorkerPoolTaskImpl : public internal::WorkerPoolTask {
  public:
   WorkerPoolTaskImpl(const WorkerPool::Callback& task,
                      const base::Closure& reply)
       : internal::WorkerPoolTask(reply),
         task_(task) {}
 
   virtual void Run(RenderingStats* rendering_stats) OVERRIDE {
     task_.Run(rendering_stats);
   }
 
+  virtual void DeferToThread(base::Thread* thread) OVERRIDE {}
+
  private:
   WorkerPool::Callback task_;
 };
 
 const char* kWorkerThreadNamePrefix = "Compositor";
 
 // Allow two pending tasks per worker. This keeps resource usage
 // low while making sure workers aren't unnecessarily idle.
 const int kNumPendingTasksPerWorker = 2;
 
+// Limits for the total number of cheap tasks we are allowed to perform
+// during a single frame and the time spent running those tasks.
+// TODO(skyostil): Determine these limits more dynamically.
+const int kMaxCheapTaskCount = 6;
+const int kMaxCheapTaskMilliseconds = 6;

[reveman, 2013/02/13 22:17:36]

maybe you can use the same time limit for this as the tick interval once
https://codereview.chromium.org/12217105/ lands.

+
 }  // namespace
 
 namespace internal {
 
 WorkerPoolTask::WorkerPoolTask(const base::Closure& reply)
     : reply_(reply) {
 }
 
 WorkerPoolTask::~WorkerPoolTask() {
 }
@@ skipping 68 matching lines @@
   CHECK(!pending_tasks_.empty());
 
   scoped_ptr<internal::WorkerPoolTask> task = pending_tasks_.take_front();
   task->Completed();
 
   worker_pool_->DidNumPendingTasksChange();
 }
 
 WorkerPool::WorkerPool(size_t num_threads)
     : workers_need_sorting_(false),
-      shutdown_(false) {
+      shutdown_(false),
+      cheap_tasks_allowed_(true),
+      running_cheap_tasks_(false) {
   const std::string thread_name_prefix = kWorkerThreadNamePrefix;
   while (workers_.size() < num_threads) {
     int thread_number = workers_.size() + 1;
     workers_.push_back(new Worker(
         this,
         thread_name_prefix + StringPrintf("Worker%d", thread_number).c_str()));
   }
 }
 
 WorkerPool::~WorkerPool() {
@@ skipping 22 matching lines @@
                           reply)).PassAs<internal::WorkerPoolTask>());
 }
 
 bool WorkerPool::IsBusy() {
   Worker* worker = GetWorkerForNextTask();
 
   return worker->num_pending_tasks() >= kNumPendingTasksPerWorker;
 }
 
 void WorkerPool::SetRecordRenderingStats(bool record_rendering_stats) {
+  if (record_rendering_stats)
+    cheap_rendering_stats_.reset(new RenderingStats);
+  else
+    cheap_rendering_stats_.reset();
+
   for (WorkerVector::iterator it = workers_.begin();
        it != workers_.end(); ++it) {
     Worker* worker = *it;
     worker->set_record_rendering_stats(record_rendering_stats);
   }
 }
 
 void WorkerPool::GetRenderingStats(RenderingStats* stats) {
   stats->totalRasterizeTime = base::TimeDelta();
   stats->totalPixelsRasterized = 0;
   stats->totalDeferredImageDecodeCount = 0;
   stats->totalDeferredImageDecodeTime = base::TimeDelta();
+  if (cheap_rendering_stats_) {
+    stats->totalRasterizeTime +=
+        cheap_rendering_stats_->totalRasterizeTime;
+    stats->totalPixelsRasterized +=
+        cheap_rendering_stats_->totalPixelsRasterized;
+    stats->totalDeferredImageDecodeCount +=
+        cheap_rendering_stats_->totalDeferredImageDecodeCount;
+    stats->totalDeferredImageDecodeTime +=
+        cheap_rendering_stats_->totalDeferredImageDecodeTime;
+  }
   for (WorkerVector::iterator it = workers_.begin();
        it != workers_.end(); ++it) {
     Worker* worker = *it;
     CHECK(worker->rendering_stats());
     stats->totalRasterizeTime +=
         worker->rendering_stats()->totalRasterizeTime;
     stats->totalPixelsRasterized +=
         worker->rendering_stats()->totalPixelsRasterized;
     stats->totalDeferredImageDecodeCount +=
         worker->rendering_stats()->totalDeferredImageDecodeCount;
@@ skipping 13 matching lines @@
 }
 
 void WorkerPool::SortWorkersIfNeeded() {
   if (!workers_need_sorting_)
     return;
 
   std::sort(workers_.begin(), workers_.end(), NumPendingTasksComparator());
   workers_need_sorting_ = false;
 }
 
+void WorkerPool::SetCheapTasksAllowed(bool allowed) {
+  cheap_tasks_allowed_ = allowed;
+}
+
+bool WorkerPool::CanPostCheapTask() const {
+  return cheap_tasks_allowed_ &&
+      pending_cheap_tasks_.size() < kMaxCheapTaskCount;
+}
+
+void WorkerPool::PostCheapTask(scoped_ptr<internal::WorkerPoolTask> task) {
+  DCHECK(CanPostCheapTask());
+  pending_cheap_tasks_.push_back(task.Pass());
+}
+
+bool WorkerPool::RunCheapTasks() {
+  if (running_cheap_tasks_)
+    return false;
+  running_cheap_tasks_ = true;
+
+  // Run as many cheap tasks as we can within the time limit.
+  TRACE_EVENT0("cc", "WorkerPool::RunCheapTasks");
+  bool ran_cheap_tasks = false;
+  base::TimeTicks deadline = base::TimeTicks::Now() +
+      base::TimeDelta::FromMilliseconds(kMaxCheapTaskMilliseconds);
+  while (pending_cheap_tasks_.size()) {
+    ran_cheap_tasks = true;
+    scoped_ptr<internal::WorkerPoolTask> task =
+        pending_cheap_tasks_.take_front();
+    task->Run(cheap_rendering_stats_.get());
+    task->Completed();
+    if (base::TimeTicks::Now() >= deadline) {
+      TRACE_EVENT_INSTANT0("cc", "WorkerPool::RunCheapTasks out of time");
+      break;
+    }
+  }
+
+  // Defer remaining tasks to worker threads.
+  while (pending_cheap_tasks_.size()) {
+    scoped_ptr<internal::WorkerPoolTask> task =
+        pending_cheap_tasks_.take_front();
+    Worker* worker = GetWorkerForNextTask();
+    task->DeferToThread(worker);
+    worker->PostTask(task.Pass());
+  }
+  running_cheap_tasks_ = false;
+  return ran_cheap_tasks;
+}
+
 }  // namespace cc