Issue 12194007: Revert 180055: Very likely caused http://crbug.com/173885

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12194007: Revert 180055: Very likely caused http://crbug.com/173885 (Closed)

Created:
7 years, 10 months ago by Nico

Modified:
7 years, 10 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 180055: Very likely caused http://crbug.com/173885 > Moving chrome://tracing to content. > > BUG=169170 > Review URL: https://codereview.chromium.org/12088099 TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180282

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -559 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/webui/tracing_ui.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/tracing_ui.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	content/browser/tracing/OWNERS	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	content/browser/tracing/tracing_ui.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	content/browser/tracing/tracing_ui.cc	View	1 chunk	+0 lines, -492 lines	0 comments	Download
M	content/browser/webui/content_web_ui_controller_factory.cc	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	content/content_browser.gypi	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/content_resources.grd	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	content/public/browser/content_browser_client.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	content/public/browser/content_browser_client.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/public/common/url_constants.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/url_constants.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/gritsettings/resource_ids	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages