Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1219313002:
DevTools: support targets that don't have Resource agent (Closed)
|
Created:
5 years, 5 months ago by yurys Modified:
5 years, 5 months ago CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionDevTools: support targets that don't have Resource agent
We already supported this for dedicated workers, this CL extends this functionality to other types of targets (e.g. standalone v8).
BUG=None
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198315
Patch Set 1 #
Total comments: 2
Messages
Total messages: 20 (8 generated)
yurys@chromium.org changed reviewers: + pfeldman@chromium.org, sergeyv@chromium.org
The CQ bit was checked by yurys@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219313002/1
https://codereview.chromium.org/1219313002/diff/1/Source/devtools/front_end/s... File Source/devtools/front_end/sdk/ResourceTreeModel.js (right): https://codereview.chromium.org/1219313002/diff/1/Source/devtools/front_end/s... Source/devtools/front_end/sdk/ResourceTreeModel.js:117: // FIXME: support targets that don't have resourceTreeModel. This clearly breaks something :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...) (exceeded global retry quota)
https://codereview.chromium.org/1219313002/diff/1/Source/devtools/front_end/s... File Source/devtools/front_end/sdk/ResourceTreeModel.js (right): https://codereview.chromium.org/1219313002/diff/1/Source/devtools/front_end/s... Source/devtools/front_end/sdk/ResourceTreeModel.js:117: // FIXME: support targets that don't have resourceTreeModel. All the tests are passing and it works fine on usual scenarios. What breakages do you mean? On 2015/07/02 20:28:07, pfeldman wrote: > This clearly breaks something :)
The CQ bit was checked by yurys@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219313002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yurys@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219313002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/61737)
The CQ bit was checked by yurys@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219313002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198315 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
