Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: webkit/fileapi/file_system_mount_point_provider.h

Issue 12193007: Deprecate MountPointProvider::IsAccessAllowed in favor of GetPermissionPolicy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: base::FilePath fix Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_system_mount_point_provider.h
diff --git a/webkit/fileapi/file_system_mount_point_provider.h b/webkit/fileapi/file_system_mount_point_provider.h
index 2e1937278671234377f542078b145516b72fd8b4..6bc8300b3da1b59cd31c72e7450fcfd14ec6d7f6 100644
--- a/webkit/fileapi/file_system_mount_point_provider.h
+++ b/webkit/fileapi/file_system_mount_point_provider.h
@@ -60,13 +60,6 @@ class WEBKIT_STORAGE_EXPORT FileSystemMountPointProvider {
const FileSystemURL& url,
bool create) = 0;
- // Checks if access to |virtual_path| is allowed from |origin_url|.
- virtual bool IsAccessAllowed(const FileSystemURL& url) = 0;
-
- // Checks if a given |name| contains any restricted names/chars in it.
- // Callable on any thread.
- virtual bool IsRestrictedFileName(const base::FilePath& filename) const = 0;
-
// Returns the specialized FileSystemFileUtil for this mount point.
// It is ok to return NULL if the filesystem doesn't support synchronous
// version of FileUtil.
@@ -132,6 +125,13 @@ class WEBKIT_STORAGE_EXPORT FileSystemMountPointProvider {
class ExternalFileSystemMountPointProvider
: public FileSystemMountPointProvider {
public:
+ // Returns true if |url| is allowed to be accessed.
+ // This is supposed to perform ExternalFileSystem-specific security
+ // checks. This method is also likely to be called by
+ // FileSystemMountPointProvider::GetPermissionPolicy as
+ // GetPermissionPolicy is supposed to perform fileapi-generic security
+ // checks (which likely need to include ExternalFileSystem-specific checks).
+ virtual bool IsAccessAllowed(const fileapi::FileSystemURL& url) const = 0;
// Returns the list of top level directories that are exposed by this
// provider. This list is used to set appropriate child process file access
// permissions.
« no previous file with comments | « webkit/chromeos/fileapi/file_access_permissions.cc ('k') | webkit/fileapi/file_system_mount_point_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698