Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: webkit/fileapi/isolated_mount_point_provider.cc

Issue 12193007: Deprecate MountPointProvider::IsAccessAllowed in favor of GetPermissionPolicy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/isolated_mount_point_provider.cc
diff --git a/webkit/fileapi/isolated_mount_point_provider.cc b/webkit/fileapi/isolated_mount_point_provider.cc
index 160a71c189aeb5c2752402c8278d7139b49e7000..45d114242c31bc33331ac24467c580f7179f6ecc 100644
--- a/webkit/fileapi/isolated_mount_point_provider.cc
+++ b/webkit/fileapi/isolated_mount_point_provider.cc
@@ -72,17 +72,6 @@ base::FilePath IsolatedMountPointProvider::GetFileSystemRootPathOnFileThread(
return base::FilePath();
}
-bool IsolatedMountPointProvider::IsAccessAllowed(const FileSystemURL& url) {
- return true;
-}
-
-bool IsolatedMountPointProvider::IsRestrictedFileName(
- const base::FilePath& filename) const {
- // TODO(kinuko): We need to check platform-specific restricted file names
- // before we actually start allowing file creation in isolated file systems.
- return false;
-}
-
FileSystemFileUtil* IsolatedMountPointProvider::GetFileUtil(
FileSystemType type) {
switch (type) {
@@ -125,7 +114,7 @@ FilePermissionPolicy IsolatedMountPointProvider::GetPermissionPolicy(
const FileSystemURL& url, int permissions) const {
if (url.type() == kFileSystemTypeDragged && url.path().empty()) {
// The root directory of the dragged filesystem must be always read-only.
- if (permissions != kReadFilePermissions)
+ if (permissions & ~fileapi::kReadFilePermissions)
return FILE_PERMISSION_ALWAYS_DENY;
}
// Access to isolated file systems should be checked using per-filesystem

Powered by Google App Engine
This is Rietveld 408576698