Deprecate MountPointProvider::IsAccessAllowed in favor of GetPermissionPolicy

chrome/browser/chromeos/extensions/file_handler_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_handler_util.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/i18n/case_conversion.h"
 #include "base/json/json_writer.h"
@@ skipping 641 matching lines @@
 
   if (!external_provider)
     return false;
 
   for (size_t i = 0; i < files.size(); ++i) {
     // Make sure this url really being used by the right caller extension.
     if (source_url_.GetOrigin() != files[i].origin())
       return false;
 
     if (!chromeos::CrosMountPointProvider::CanHandleURL(files[i]) ||
-        !external_provider->IsAccessAllowed(files[i])) {
+        (external_provider->GetPermissionPolicy(
+            files[i], fileapi::kReadFilePermissions) ==
+            fileapi::FILE_PERMISSION_ALWAYS_DENY)) {

[kinuko, 2013/02/04 08:58:25]

Maybe this change needs some more care too

[tbarzic, 2013/02/05 00:09:34]

hmm, this should be ok.. to be honest I've started thinking about removing this
part of code and replacing it with something like:
CHECK(TheExtensionHasFileBrowserPrivatePermission(file_browser_id_), but that's
not much related to this cl.

       return false;
     }
   }
 
   return true;
 }
 
 // TODO(kaznacheev): Remove this method and inline its implementation at the
 // only place where it is used (DriveTaskExecutor::OnAppAuthorized)
 Browser* FileTaskExecutor::GetBrowser() const {
@@ skipping 390 matching lines @@
     extensions::LaunchPlatformAppWithFileHandler(profile(), GetExtension(),
         action_id_, file_urls[i].path());
   }
 
   if (!done.is_null())
     done.Run(true);
   return true;
 }
 
 } // namespace file_handler_util