Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1219263003: Update config name for WebRTC delay-agnostic echo cancellation (Closed)

Created:
5 years, 5 months ago by hlundin-chromium
Modified:
5 years, 5 months ago
Reviewers:
ajm
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, bjornv
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update config name for WebRTC delay-agnostic echo cancellation This change switches from the old config name ReportedDelay to the new name DelayAgnostic. The old name is deprecated in WebRTC and will be removed. Note: the logic is inversed with the name change. That is, ReportedDelay==false corresponds to DelayAgnostic==true. BUG=webrtc:4651 Committed: https://crrev.com/c5d38a2a23004d45cabbca5792b51dcb94c16a94 Cr-Commit-Position: refs/heads/master@{#337286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/media_stream_audio_processor.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hlundin-chromium
ajm, Please, take a look. Thanks!
5 years, 5 months ago (2015-07-02 14:16:48 UTC) #2
ajm
lgtm
5 years, 5 months ago (2015-07-03 04:00:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219263003/1
5 years, 5 months ago (2015-07-03 04:01:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-03 04:58:50 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 05:00:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5d38a2a23004d45cabbca5792b51dcb94c16a94
Cr-Commit-Position: refs/heads/master@{#337286}

Powered by Google App Engine
This is Rietveld 408576698