Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1219233003: Fix some clang warnings with -Wmissing-braces in v8. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix some clang warnings with -Wmissing-braces in v8. Clang warns if there are missing braces around a subobject initializer. The most common idiom that triggers this is: STRUCT s = {0}; if the first field of STRUCT is itself a struct. This can be more simply written as: STRUCT s = {}; which also prevents the warning from firing. BUG=chromium:505297 LOG=n Committed: https://crrev.com/76ea6ae7445713c683369ccf5fa1e9102dd9c6b8 Cr-Commit-Position: refs/heads/master@{#29437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/base/sys-info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 5 months ago (2015-07-01 23:29:46 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-02 07:00:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219233003/1
5 years, 5 months ago (2015-07-02 07:00:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 07:25:54 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 07:26:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76ea6ae7445713c683369ccf5fa1e9102dd9c6b8
Cr-Commit-Position: refs/heads/master@{#29437}

Powered by Google App Engine
This is Rietveld 408576698