Add new simple disk cache backend.

net/net.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
 
     'linux_link_kerberos%': 0,
+    'use_very_simple_backend%': 0,

[rvargas (doing something else), 2013/02/06 03:28:40]

do we really need a gyp variable?

[gavinp, 2013/02/08 23:17:51]

Can you tell me more about adding defines without using one? I don't understand
the alternative.

     'conditions': [
       ['chromeos==1 or OS=="android" or OS=="ios"', {
         # Disable Kerberos on ChromeOS, Android and iOS, at least for now.
         # It needs configuration (krb5.conf and so on).
         'use_kerberos%': 0,
       }, {  # chromeos == 0
         'use_kerberos%': 1,
       }],
       ['OS=="android"', {
         # The way the cache uses mmap() is inefficient on some Android devices.
@@ skipping 25 matching lines @@
       'variables': { 'enable_wexit_time_destructors': 1, },
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:base_i18n',
         '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../crypto/crypto.gyp:crypto',
         '../sdch/sdch.gyp:sdch',
         '../third_party/icu/icu.gyp:icui18n',
         '../third_party/icu/icu.gyp:icuuc',
+        '../third_party/smhasher/smhasher.gyp:murmurhash3',
         '../third_party/zlib/zlib.gyp:zlib',
         'net_resources',
       ],
       'sources': [
         'android/gurl_utils.cc',
         'android/gurl_utils.h',
         'android/net_jni_registrar.cc',
         'android/net_jni_registrar.h',
         'android/network_change_notifier_android.cc',
         'android/network_change_notifier_android.h',
@@ skipping 333 matching lines @@
         'disk_cache/sparse_control.h',
         'disk_cache/stats.cc',
         'disk_cache/stats.h',
         'disk_cache/stats_histogram.cc',
         'disk_cache/stats_histogram.h',
         'disk_cache/storage_block-inl.h',
         'disk_cache/storage_block.h',
         'disk_cache/stress_support.h',
         'disk_cache/trace.cc',
         'disk_cache/trace.h',
+        'disk_cache/very_simple/very_simple_backend_impl.cc',
+        'disk_cache/very_simple/very_simple_backend_impl.h',
+        'disk_cache/very_simple/very_simple_disk_format.h',
+        'disk_cache/very_simple/very_simple_entry_impl.cc',
+        'disk_cache/very_simple/very_simple_entry_impl.h',
+        'disk_cache/very_simple/very_simple_synchronous_entry.cc',
+        'disk_cache/very_simple/very_simple_synchronous_entry.h',
         'disk_cache/flash/format.h',
         'disk_cache/flash/log_store.cc',
         'disk_cache/flash/log_store.h',
         'disk_cache/flash/log_store_entry.cc',
         'disk_cache/flash/log_store_entry.h',
         'disk_cache/flash/segment.cc',
         'disk_cache/flash/segment.h',
         'disk_cache/flash/storage.cc',
         'disk_cache/flash/storage.h',
         'dns/address_sorter.h',
@@ skipping 604 matching lines @@
           'defines': [
             'ENABLE_BUILT_IN_DNS',
           ]
         }, { # else
           'sources!': [
             'dns/address_sorter_posix.cc',
             'dns/address_sorter_posix.h',
             'dns/dns_client.cc',
           ],
         }],
+        ['use_very_simple_backend==1', {
+          'defines': [
+            'USE_VERY_SIMPLE_BACKEND',
+          ]
+        }, { # else
+          'sources!': [

[rvargas (doing something else), 2013/02/06 03:28:40]

why remove these files?

[gavinp, 2013/02/08 23:27:21]

I copied the pattern from what our custom DNS resolver does.

[rvargas (doing something else), 2013/02/13 01:48:46]

I still think this is not the right thing to do... unless you have a strong
reason to avoid compilation of the code by the bots. For example, the flash
backend files compile all the time (and the unit tests run)

+            'disk_cache/very_simple/very_simple_backend_impl.cc',

[pasko-google - do not use, 2013/02/05 21:20:33]

I prefer runtime command-line flag because:
1. no need to gclient runhooks and rebuild, easier to test on bots
2. no ugly ifdefs
3. no repeating ourselves when removing the files conditionally in gyp
4. adds only tiny amount of code

Though it is not a super-strong opinion, I am OK following Ricardo's preference,
I do not know his opinion on it yet

+            'disk_cache/very_simple/very_simple_backend_impl.h',
+            'disk_cache/very_simple/very_simple_disk_format.h',
+            'disk_cache/very_simple/very_simple_entry_impl.cc',
+            'disk_cache/very_simple/very_simple_entry_impl.h',
+            'disk_cache/very_simple/very_simple_synchronous_entry.cc',
+            'disk_cache/very_simple/very_simple_synchronous_entry.h',
+          ],
+        }],
         ['use_openssl==1', {
             'sources!': [
               'base/cert_database_nss.cc',
               'base/cert_verify_proc_nss.cc',
               'base/cert_verify_proc_nss.h',
               'base/client_cert_store_impl_nss.cc',
               'base/crypto_module_nss.cc',
               'base/keygen_handler_nss.cc',
               'base/nss_cert_database.cc',
               'base/nss_cert_database.h',
@@ skipping 1407 matching lines @@
                 '--result', '<@(_outputs)',
                 '--isolate', 'net_unittests.isolate',
               ],
             },
           ],
         },
       ],
     }],
   ],
 }