net/DEPS - Issue 12192005: Add new simple disk cache backend.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/DEPS

Issue 12192005: Add new simple disk cache backend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase to trunk (::FilePath --> base::FilePath) Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+crypto",	2 "+crypto",

3 "+dbus",	3 "+dbus",

4 "+jni",	4 "+jni",

5 "+third_party/apple_apsl",	5 "+third_party/apple_apsl",

6 "+third_party/libevent",	6 "+third_party/libevent",

7 "+third_party/nss",	7 "+third_party/nss",

	8 "+third_party/smhasher",
	rvargas (doing something else) 2013/02/06 03:28:40 I'm fine with switching to murmur, but I have the I'm fine with switching to murmur, but I have the impression that the result of the hash is not the same across architectures. Is that not the case? gavinp 2013/02/08 23:17:51 Well, there's different versions for different arc Show quoted text On 2013/02/06 03:28:40, rvargas wrote: > I'm fine with switching to murmur, but I have the impression that the result of > the hash is not the same across architectures. Is that not the case? Well, there's different versions for different architectures x86 and x64. They both run on the other architecture, but at reduced speed. This CL just uses the x86 one, which works, but isn't optimal on the x64 platform. For endianness, we're sort of pooched anyway. Thankfully our magic number check catches that early. So to use it properly, you need to detect which CPU is in use, then use the right one, and save that in the cache, so that you use the same one in the future. That's not simple. So I'm switching back to using very fast hash from base/, which is the simple choice. A future person concerned with the last ounce of performance can move murmur3 into base/, and write up logic to help pick the right on.
8 "+third_party/zlib",	9 "+third_party/zlib",

9 "+sdch/open-vcdiff",	10 "+sdch/open-vcdiff",

10 "+v8",	11 "+v8",

11 ]	12 ]

12	13

13 skip_child_includes = [	14 skip_child_includes = [

14 "third_party",	15 "third_party",

15 "tools/flip_server",	16 "tools/flip_server",

16 ]	17 ]

OLD	NEW

« no previous file with comments | « no previous file | net/disk_cache/backend_impl.cc » ('j') | net/disk_cache/backend_impl.cc » ('J')