Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 1219193002: Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #2 id:30001 of https://codereview.chromium.org/1210053003/) Reason for revert: Perf regression: https://code.google.com/p/chromium/issues/detail?id=505564 Original issue's description: > Fix SkTileImageFilter clipping/cropRect interaction issue > > BUG=499499 > > Committed: https://skia.googlesource.com/skia/+/157bcd0840b578060dbc3365daafffc6837da391 TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=499499 Committed: https://skia.googlesource.com/skia/+/ebaf6a69bf604c85185e23aca3fb93308e747ff5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -162 lines) Patch
D gm/cropdisp.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 3 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bsalomon
Created Revert of Fix SkTileImageFilter clipping/cropRect interaction issue
5 years, 5 months ago (2015-07-01 18:02:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219193002/1
5 years, 5 months ago (2015-07-01 18:02:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ebaf6a69bf604c85185e23aca3fb93308e747ff5
5 years, 5 months ago (2015-07-01 18:02:59 UTC) #3
reed2
is this revert causing the layoutests failures in the DEPS roll?
5 years, 5 months ago (2015-07-03 03:29:21 UTC) #5
jvanverth1
On 2015/07/03 03:29:21, reed2 wrote: > is this revert causing the layoutests failures in the ...
5 years, 5 months ago (2015-07-03 12:27:22 UTC) #6
jvanverth1
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1207353004/ by jvanverth@google.com. ...
5 years, 5 months ago (2015-07-03 12:48:41 UTC) #7
reed2
We might revert this, as you've done, or we might revert the new LayoutTest images ...
5 years, 5 months ago (2015-07-03 12:51:01 UTC) #9
robertphillips
5 years, 5 months ago (2015-07-06 13:32:27 UTC) #11
Message was sent while issue was closed.
Here is the suppression CL that was landed along with the original version of
the patch (https://codereview.chromium.org/1216733002/). So, yeah, we can just
suppress.

Powered by Google App Engine
This is Rietveld 408576698