content/browser/web_contents/opened_by_dom_browsertest.cc - Issue 1219163002: Enable OpenedByDOMTest.CrossProcessPopup test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/opened_by_dom_browsertest.cc

Issue 1219163002: Enable OpenedByDOMTest.CrossProcessPopup test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Bug-496923-Enable.AllowTargetedNavigationsAfterSwap

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/opened_by_dom_browsertest.cc

diff --git a/content/browser/web_contents/opened_by_dom_browsertest.cc b/content/browser/web_contents/opened_by_dom_browsertest.cc

index dab6eb8d3180845a63c920b7e0003dd9e724d31d..f505afc35795e4daa65c2c5b6d609dd595005a2c 100644

--- a/content/browser/web_contents/opened_by_dom_browsertest.cc

+++ b/content/browser/web_contents/opened_by_dom_browsertest.cc

@@ -114,8 +114,7 @@ IN_PROC_BROWSER_TEST_F(OpenedByDOMTest, Popup) {

// Tests that window.close() works in a popup window that has navigated a few

// times and swapped processes.

-// Crashes on all platforms. http://crbug.com/399709

-IN_PROC_BROWSER_TEST_F(OpenedByDOMTest, DISABLED_CrossProcessPopup) {

+IN_PROC_BROWSER_TEST_F(OpenedByDOMTest, CrossProcessPopup) {

host_resolver()->AddRule("*", "127.0.0.1");

ASSERT_TRUE(test_server()->Start());

« no previous file with comments | « no previous file | no next file » | no next file with comments »