Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1219133004: Remove usage of to-be-deprecated APIs from samples (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove usage of to-be-deprecated APIs from samples BUG=v8:4134 R=vogelheim@chromium.org LOG=n Committed: https://crrev.com/ebadb68f02ee5413b77924876f0621d2fb0aa108 Cr-Commit-Position: refs/heads/master@{#29452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -156 lines) Patch
M samples/hello-world.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M samples/process.cc View 28 chunks +112 lines, -86 lines 0 comments Download
M samples/samples.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M samples/shell.cc View 12 chunks +86 lines, -67 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-02 15:12:49 UTC) #1
vogelheim
lgtm
5 years, 5 months ago (2015-07-02 15:26:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219133004/1
5 years, 5 months ago (2015-07-02 15:28:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 15:42:38 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 15:42:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebadb68f02ee5413b77924876f0621d2fb0aa108
Cr-Commit-Position: refs/heads/master@{#29452}

Powered by Google App Engine
This is Rietveld 408576698