chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc - Issue 1219133003: Contextual Search UI changes for custom tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc

Issue 1219133003: Contextual Search UI changes for custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use fadingInPercentage and fadingOutPercentage, get rid of PanelBase#isCloseIconVisible() Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.h ('k') | chrome/browser/android/feature_utilities.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc

diff --git a/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc b/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc

index 02a23e8a2d332f7c971395effd66d5e6f40d6ea8..e8584fe3d896a69c2fbb66131ee433f50712102a 100644

--- a/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc

+++ b/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc

@@ -30,6 +30,7 @@ void ContextualSearchSceneLayer::UpdateContextualSearchLayer(

jint search_provider_icon_resource_id,

jint search_icon_resource_id,

jint arrow_up_resource_id,

+ jint close_icon_resource_id,

jint progress_bar_background_resource_id,

jint progress_bar_resource_id,

jint search_promo_resource_id,

@@ -55,6 +56,8 @@ void ContextualSearchSceneLayer::UpdateContextualSearchLayer(

jboolean arrow_icon_visible,

jfloat arrow_icon_opacity,

jfloat arrow_icon_rotation,

+ jboolean close_icon_visible,

+ jfloat close_icon_opacity,

jboolean progress_bar_visible,

jfloat progress_bar_y,

jfloat progress_bar_height,

@@ -87,6 +90,7 @@ void ContextualSearchSceneLayer::UpdateContextualSearchLayer(

search_provider_icon_resource_id,

search_icon_resource_id,

arrow_up_resource_id,

+ close_icon_resource_id,

progress_bar_background_resource_id,

progress_bar_resource_id,

search_promo_resource_id,

@@ -112,6 +116,8 @@ void ContextualSearchSceneLayer::UpdateContextualSearchLayer(

arrow_icon_visible,

arrow_icon_opacity,

arrow_icon_rotation,

+ close_icon_visible,

+ close_icon_opacity,

progress_bar_visible,

progress_bar_y,

progress_bar_height,